Changeset 95334 in vbox for trunk/src/VBox/Main/xml/Settings.cpp

Timestamp:

Jun 21, 2022 7:49:35 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

151926

Message:

GuestPropertySvc.h,Main/Settings.cpp: Made GUEST_PROP_MAX_NAME_LEN and GUEST_PROP_MAX_VALUE_LEN work like GUEST_PROP_MAX_PATTERN_LEN and be the max size of the respective strings, including the zero terminator. This way a szName[GUEST_PROP_MAX_NAME_LEN] variable will be the exact max size of a property name, rather than one byte more than the max which was the previous weirdness. bugref:10185

File:

• trunk/src/VBox/Main/xml/Settings.cpp (modified) (1 diff)

trunk/src/VBox/Main/xml/Settings.cpp

@@ -4675 +4675 @@
             /** @todo r=bird: Should add a RTCString method for this, as this may create a
              *        invalid UTF-8 encoding if we chop up a UTF-8 sequence. */
-            Assert(prop.strValue.length() + 1 >= GUEST_PROP_MAX_VALUE_LEN);
-            prop.strValue.mutableRaw()[GUEST_PROP_MAX_VALUE_LEN - 2] = '\0';
+            Assert(prop.strValue.length() + 1 > GUEST_PROP_MAX_VALUE_LEN);
+            prop.strValue.mutableRaw()[GUEST_PROP_MAX_VALUE_LEN - 1] = '\0';
             prop.strValue.jolt();
         }