Changeset 98297 in vbox for trunk/src/VBox/Main/glue/EventQueue.cpp

Timestamp:

Jan 25, 2023 1:59:25 AM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

155502

Message:

Main: rc -> hrc/vrc for all but testcases. Enabled scm rc checks accordingly. bugref:10223

File:

• trunk/src/VBox/Main/glue/EventQueue.cpp (modified) (9 diffs)

trunk/src/VBox/Main/glue/EventQueue.cpp

@@ -49 +49 @@
       mShutdown(false)
 {
-    int rc = RTCritSectInit(&mCritSect);
-    AssertRC(rc);
-
-    rc = RTSemEventCreate(&mSemEvent);
-    AssertRC(rc);
+    int vrc = RTCritSectInit(&mCritSect);
+    AssertRC(vrc);
+
+    vrc = RTSemEventCreate(&mSemEvent);
+    AssertRC(vrc);
 }
 
 EventQueue::~EventQueue(void)
 {
-    int rc = RTCritSectDelete(&mCritSect);
-    AssertRC(rc);
-
-    rc = RTSemEventDestroy(mSemEvent);
-    AssertRC(rc);
+    int vrc = RTCritSectDelete(&mCritSect);
+    AssertRC(vrc);
+
+    vrc = RTSemEventDestroy(mSemEvent);
+    AssertRC(vrc);
 
     EventQueueListIterator it  = mEvents.begin();
@@ -98 +98 @@
 {
     size_t cNumEvents;
-    int rc = RTCritSectEnter(&mCritSect);
-    if (RT_SUCCESS(rc))
+    int vrc = RTCritSectEnter(&mCritSect);
+    if (RT_SUCCESS(vrc))
     {
         if (mUserCnt == 0) /* No concurrent access allowed. */
@@ -108 +108 @@
             if (!cNumEvents)
             {
-                int rc2 = RTCritSectLeave(&mCritSect);
-                AssertRC(rc2);
-
-                rc = RTSemEventWaitNoResume(mSemEvent, cMsTimeout);
-
-                rc2 = RTCritSectEnter(&mCritSect);
-                AssertRC(rc2);
-
-                if (RT_SUCCESS(rc))
+                int vrc2 = RTCritSectLeave(&mCritSect);
+                AssertRC(vrc2);
+
+                vrc = RTSemEventWaitNoResume(mSemEvent, cMsTimeout);
+
+                vrc2 = RTCritSectEnter(&mCritSect);
+                AssertRC(vrc2);
+
+                if (RT_SUCCESS(vrc))
                 {
                     if (mShutdown)
-                        rc = VERR_INTERRUPTED;
+                        vrc = VERR_INTERRUPTED;
                     cNumEvents = mEvents.size();
                 }
             }
 
-            if (RT_SUCCESS(rc))
-                rc = processPendingEvents(cNumEvents);
+            if (RT_SUCCESS(vrc))
+                vrc = processPendingEvents(cNumEvents);
 
             Assert(mUserCnt);
@@ -131 +131 @@
         }
         else
-            rc = VERR_WRONG_ORDER;
-
-        int rc2 = RTCritSectLeave(&mCritSect);
-        if (RT_SUCCESS(rc))
-            rc = rc2;
-    }
-
-    Assert(rc != VERR_TIMEOUT || cMsTimeout != RT_INDEFINITE_WAIT);
-    return rc;
+            vrc = VERR_WRONG_ORDER;
+
+        int vrc2 = RTCritSectLeave(&mCritSect);
+        if (RT_SUCCESS(vrc))
+            vrc = vrc2;
+    }
+
+    Assert(vrc != VERR_TIMEOUT || cMsTimeout != RT_INDEFINITE_WAIT);
+    return vrc;
 }
 
@@ -154 +154 @@
         return VINF_SUCCESS;
 
-    int rc = VINF_SUCCESS;
+    int vrc = VINF_SUCCESS;
 
     EventQueueListIterator it = mEvents.begin();
@@ -166 +166 @@
         mEvents.erase(it);
 
-        int rc2 = RTCritSectLeave(&mCritSect);
-        AssertRC(rc2);
+        int vrc2 = RTCritSectLeave(&mCritSect);
+        AssertRC(vrc2);
 
         pEvent->handler();
         pEvent->Release();
 
-        rc2 = RTCritSectEnter(&mCritSect);
-        AssertRC(rc2);
+        vrc2 = RTCritSectEnter(&mCritSect);
+        AssertRC(vrc2);
 
         it = mEvents.begin();
         if (mShutdown)
         {
-            rc = VERR_INTERRUPTED;
+            vrc = VERR_INTERRUPTED;
             break;
         }
     }
 
-    return rc;
+    return vrc;
 }
 
@@ -208 +208 @@
 BOOL EventQueue::postEvent(Event *pEvent)
 {
-    int rc = RTCritSectEnter(&mCritSect);
-    if (RT_SUCCESS(rc))
+    int vrc = RTCritSectEnter(&mCritSect);
+    if (RT_SUCCESS(vrc))
     {
         try
@@ -231 +231 @@
 
             /* Leave critical section before signalling event. */
-            rc = RTCritSectLeave(&mCritSect);
-            if (RT_SUCCESS(rc))
-            {
-                int rc2 = RTSemEventSignal(mSemEvent);
-                AssertRC(rc2);
+            vrc = RTCritSectLeave(&mCritSect);
+            if (RT_SUCCESS(vrc))
+            {
+                int vrc2 = RTSemEventSignal(mSemEvent);
+                AssertRC(vrc2);
             }
         }
@@ -241 +241 @@
         {
             NOREF(ba);
-            rc = VERR_NO_MEMORY;
-        }
-
-        if (RT_FAILURE(rc))
-        {
-            int rc2 = RTCritSectLeave(&mCritSect);
-            AssertRC(rc2);
-        }
-    }
-
-    return RT_SUCCESS(rc) ? TRUE : FALSE;
+            vrc = VERR_NO_MEMORY;
+        }
+
+        if (RT_FAILURE(vrc))
+        {
+            int vrc2 = RTCritSectLeave(&mCritSect);
+            AssertRC(vrc2);
+        }
+    }
+
+    return RT_SUCCESS(vrc) ? TRUE : FALSE;
 }