restoring machine state fails, because subversion rev is 0 for OSE => Fixed in SVN

[dfries]

When not compiling out of subversion (that is compiling source that wasn't checked out of subversion) the revision is seen as 0, which causes restoring the machine state to fail with a version mismatch VERR_SSM_INTEGRITY_VBOX_VERSION.

log entries for restore,
VirtualBox VM 4.2.8_OSE r0 linux.amd64 (Feb 28 2013 15:27:49) release log
SSM: Incorrect version values: 4.2.8.r0
The saved state file '...Snapshots/2013-02-28T21-59-00-115270000Z.sav' is invalid (VERR_SSM_INTEGRITY_VBOX_VERSION). Delete the saved state and try again

Steps to reproduce, Extract VirtualBox-4.2.8.tar.bz2, compile `dpkg-buildpackage -rfakeroot` install, run a VM, save the machine state, restore and it fails.

The error is in src/VBox/VMM/VMMR3/SSM.cpp line 7356 function ssmR3ValidateHeaderInfo, because VBOX_SVN_REV was 0 when writing the header, then when reading the check
|| pSSM->u.Read.u32SvnRev == 0
is true causing an error to be reported. Presumably the code check was treating 0 as inavlid, except that is the value it just wrote to the header. Commenting out that line of code, compiling, and installing allows the machine state to load and run.

I don't know if the tar.bz2 should include the subversion revision that it was compiled from or how this should be resolved. I assume it was present in all 4.2 releases, at least I think that is when I noticed the releases failing.

[Frank Mehnert]

Thanks for the report! This problem will be fixed in the next maintenance release (after 4.2.10).

[Frank Mehnert]

Fixed in VBox 4.2.12.