VirtualBox

Opened 9 years ago

Last modified 9 years ago

#15520 reopened defect

vbox/src/VBox/Devices/Network/slirp/resolv_conf_parser.c:476: bad test ?

Reported by: dcb Owned by:
Component: network/NAT Version: VirtualBox 5.0.22
Keywords: Cc:
Guest type: other Host type: other

Description

vbox/src/VBox/Devices/Network/slirp/resolv_conf_parser.c:476]: (warning) Logical conjunction always evaluates to false: EXPR == ' ' && EXPR == '\t'.

Source code is

while (*psz && *psz == ' ' && *psz == '\t')

Attachments (3)

0 (29.9 KB ) - added by dcb 9 years ago.
cppcheck output - only the errors.
1.gz (42.0 KB ) - added by dcb 9 years ago.
gzipped cppcheck output - only the warnings
2 (262.7 KB ) - added by dcb 9 years ago.
cppcheck output - only the style messages

Download all attachments as: .zip

Change History (8)

comment:1 by Frank Mehnert, 9 years ago

Resolution: invalid
Status: newclosed

STOP SPAMMING this bugtracker.

comment:2 by Valery Ushakov, 9 years ago

Component: othernetwork/NAT
Resolution: invalid
Status: closedreopened

It actually is valid - an obvious pasto/edito; but spamming the bug tracker with individual errors is indeed not the best way to go about this.

comment:3 by dcb, 9 years ago

spamming the bug tracker with individual errors is indeed not the best way to go about this.

So if you don't want bug reports in the bug tracker, where do you want them ?

I could probably find another 20-30 bugs.

comment:4 by Valery Ushakov, 9 years ago

You are obviously running some static analysis tool. It's better to file a single bug with complete results of the run attached.

by dcb, 9 years ago

Attachment: 0 added

cppcheck output - only the errors.

by dcb, 9 years ago

Attachment: 1.gz added

gzipped cppcheck output - only the warnings

by dcb, 9 years ago

Attachment: 2 added

cppcheck output - only the style messages

comment:5 by dcb, 9 years ago

It's better to file a single bug with complete results of the run attached.

Attached. Presumably the false positives will be obvious to you.

Note: See TracTickets for help on using tickets.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette