Opened 8 years ago
#16983 new defect
Autorun.inf not correctly identified from 'file' command.
Reported by: | Socratis | Owned by: | |
---|---|---|---|
Component: | guest additions | Version: | VirtualBox 5.1.26 |
Keywords: | guest additions, autorun.inf, 'file' command | Cc: | |
Guest type: | Windows | Host type: | all |
Description
Based on a recent discussion in the forums, the contents of the "Autorun.inf
" file used in the GAs Windows installer, could/should be slightly modified to bring it in "compliance" with the 'file
' command found in almost all Unix-based OSes.
The problem arises from the fact that a proper "Autorun.inf
" file should start with the "[autorun]
" text. The current "Autorun.inf
" file starts with the license (a comment). If the "[autorun]
" entry gets moved at the beginning of the file, before the comment, everyone/everything is happy.
Patch is published under the terms of the MIT license. Both lines ;) :
--- /Users/Shared/VirtualBox/Source/VirtualBox-5.1.26/src/VBox/Additions/WINNT/Installer/ISO/AUTORUN.INF 2017-07-27 16:13:52.000000000 +0300 +++ /Users/Shared/VirtualBox/Source/vbox/src/VBox/Additions/WINNT/Installer/ISO/AUTORUN.INF 2017-08-06 09:30:40.000000000 +0300 @@ -1,5 +1,6 @@ +[autorun] ; -; Copyright (C) 2006-2016 Oracle Corporation +; Copyright (C) 2006-2017 Oracle Corporation ; ; This file is part of VirtualBox Open Source Edition (OSE), as ; available from http://www.virtualbox.org. This file is free software; @@ -10,7 +11,6 @@ ; hope that it will be useful, but WITHOUT ANY WARRANTY of any kind. ; -[autorun] open=VBoxWindowsAdditions.exe icon=VBoxWindowsAdditions.exe label=VirtualBox Guest Additions
Before the patch:
$ file /Users/Shared/VirtualBox/Source/VirtualBox-5.1.26/src/VBox/Additions/WINNT/Installer/ISO/AUTORUN.INF AUTORUN.INF: ASCII English text, with CRLF line terminators
After the patch:
$ file /Users/Shared/VirtualBox/Source/vbox/src/VBox/Additions/WINNT/Installer/ISO/AUTORUN.INF AUTORUN.INF: Microsoft Windows Autorun file.