vboxweb.cpp fails to compile with gSoap 2.8.103

[Derek Schrock]

It appears gSoap 2.8.103 change the soap_socket_errno macro used by src/VBox/Main/webservice/vboxweb.cpp

kBuild: Compiling vboxsoap - /wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-5.2.34/out/freebsd.amd64/release/obj/webservice/soapC-3.cpp
/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-5.2.34/src/VBox/Main/webservice/vboxweb.cpp:947:38: error: called object type 'int' is not a function or function pointer
                       if (soap_socket_errno(soap.master) == SOAP_EINTR)
                           ~~~~~~~~~~~~~~~~~^

From gSoap 2.8.103 gsoap/stdsoap2.h:

#ifdef WIN32
# ifdef UNDER_CE
#  define soap_errno GetLastError()
#  define soap_socket_errno GetLastError()
#  define soap_reset_errno SetLastError(0)
# else
#  define soap_errno errno
#  define soap_socket_errno WSAGetLastError()
#  define soap_reset_errno _set_errno(0)
# endif
#else
# ifndef WITH_NOIO
#  define soap_errno errno
#  define soap_socket_errno errno
#  define soap_reset_errno (errno = ENOENT)
# else
#  define soap_errno 0
#  define soap_socket_errno 0
#  define soap_reset_errno
# endif
#endif

[LocutusOfBorg]

The attached file should fix the build, I'm testing it right now on Ubuntu ​https://launchpad.net/ubuntu/+source/virtualbox/6.1.12-dfsg-6build2/+build/19641753

[LocutusOfBorg]

looks like it did the job

[LocutusOfBorg]

changed the gsoap version with 208103

[Klaus Espenlaub]

Applied to VirtualBox trunk and 6.1 source code repositories. Our revision 140250 and later will have the fix. First release with the adjustment will be 6.1.16.