Assertion in MachineImpl.cpp can never fail => fixed in svn/6.1.x x>16

[nfeske]

At the beginning of the function Machine::initDataAndChildObjects, a boolean expression is passed as RC argument to the macro AssertComRCReturn:

    AssertComRCReturn(   getObjectState().getState() == ObjectState::InInit
                      || getObjectState().getState() == ObjectState::Limited, E_FAIL);

When compiling with XPCOM, the value of the expression can never yield a NS error value (bit 31 is never set).

I presume that AssertComRCReturn should be replaced by AssertReturn.

[paulson]

Thanks for the bug report, nicely spotted! We've fixed this in the development release of VirtualBox and also in the 6.1 branch of VirtualBox. Thus the fix will be part of the next maintenance release of VirtualBox 6.1.x.