Changeset 103256 in vbox for trunk/src/VBox/VMM/VMMAll/IEMAllInstVexMap2.cpp.h

Timestamp:

Feb 7, 2024 3:07:09 PM (13 months ago)

Author:

vboxsync

Message:

VMM/IEM: Fix regression causing alignment exceptions for SSE/AVX based unaligned data fetches and stores which are handled fine on real hardware, bugref:9898

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllInstVexMap2.cpp.h (modified) (14 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllInstVexMap2.cpp.h

@@ -547 +547 @@
 
 /** Body for the vpmov{s,z}x* instructions. */
-#define IEMOP_BODY_VPMOV_S_Z(a_Instr, a_SrcWidth) \
+#define IEMOP_BODY_VPMOV_S_Z(a_Instr, a_SrcWidth, a_VexLengthMemFetch) \
     uint8_t bRm; IEM_OPCODE_GET_NEXT_U8(&bRm); \
     if (IEM_IS_MODRM_REG_MODE(bRm)) \
@@ -606 +606 @@
             IEM_MC_MAYBE_RAISE_AVX_RELATED_XCPT(); \
             IEM_MC_PREPARE_AVX_USAGE(); \
-            IEM_MC_FETCH_MEM_U128(uSrc, pVCpu->iem.s.iEffSeg, GCPtrEffSrc); \
+            a_VexLengthMemFetch(uSrc, pVCpu->iem.s.iEffSeg, GCPtrEffSrc); \
             IEM_MC_CALL_VOID_AIMPL_2(IEM_SELECT_HOST_OR_FALLBACK(fAvx2, iemAImpl_ ## a_Instr ## _u256, \
                                                                  iemAImpl_ ## a_Instr ## _u256_fallback), \
@@ -641 +641 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVSXBW, vpmovsxbw, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovsxbw, 64);
+    IEMOP_BODY_VPMOV_S_Z(vpmovsxbw, 64, IEM_MC_FETCH_MEM_U128_NO_AC);
 }
 
@@ -650 +650 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVSXBD, vpmovsxbd, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovsxbd, 32);
+    IEMOP_BODY_VPMOV_S_Z(vpmovsxbd, 32, IEM_MC_FETCH_MEM_U128);
 }
 
@@ -659 +659 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVSXBQ, vpmovsxbq, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovsxbq, 16);
+    IEMOP_BODY_VPMOV_S_Z(vpmovsxbq, 16, IEM_MC_FETCH_MEM_U128);
 }
 
@@ -668 +668 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVSXWD, vpmovsxwd, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovsxwd, 64);
+    IEMOP_BODY_VPMOV_S_Z(vpmovsxwd, 64, IEM_MC_FETCH_MEM_U128_NO_AC);
 }
 
@@ -677 +677 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVSXWQ, vpmovsxwq, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovsxwq, 32);
+    IEMOP_BODY_VPMOV_S_Z(vpmovsxwq, 32, IEM_MC_FETCH_MEM_U128);
 }
 
@@ -686 +686 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVSXDQ, vpmovsxdq, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovsxdq, 64);
+    IEMOP_BODY_VPMOV_S_Z(vpmovsxdq, 64, IEM_MC_FETCH_MEM_U128_NO_AC);
 }
 
@@ -820 +820 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVZXBW, vpmovzxbw, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovzxbw, 64);
+    IEMOP_BODY_VPMOV_S_Z(vpmovzxbw, 64, IEM_MC_FETCH_MEM_U128_NO_AC);
 }
 
@@ -829 +829 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVZXBD, vpmovzxbd, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovzxbd, 32);
+    IEMOP_BODY_VPMOV_S_Z(vpmovzxbd, 32, IEM_MC_FETCH_MEM_U128);
 }
 
@@ -838 +838 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVZXBQ, vpmovzxbq, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovzxbq, 16);
+    IEMOP_BODY_VPMOV_S_Z(vpmovzxbq, 16, IEM_MC_FETCH_MEM_U128);
 }
 
@@ -847 +847 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVZXWD, vpmovzxwd, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovzxwd, 64);
+    IEMOP_BODY_VPMOV_S_Z(vpmovzxwd, 64, IEM_MC_FETCH_MEM_U128_NO_AC);
 }
 
@@ -856 +856 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVZXWQ, vpmovzxwq, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovzxwq, 32);
+    IEMOP_BODY_VPMOV_S_Z(vpmovzxwq, 32, IEM_MC_FETCH_MEM_U128);
 }
 
@@ -865 +865 @@
      /** @todo r=aeichner Review code, the naming of this function and the parameter type specifiers. */
     IEMOP_MNEMONIC2(VEX_RM, VPMOVZXDQ, vpmovzxdq, Vx, Wq, DISOPTYPE_HARMLESS, 0);
-    IEMOP_BODY_VPMOV_S_Z(vpmovzxdq, 64);
+    IEMOP_BODY_VPMOV_S_Z(vpmovzxdq, 64, IEM_MC_FETCH_MEM_U128_NO_AC);
 }