Changeset 106101 in vbox for trunk/src/VBox

Timestamp:

Sep 19, 2024 9:16:19 PM (3 months ago)

Author:

vboxsync

Message:

VMM/IEM: More native eflag stats. Added IEMNATIVE_WITH_EFLAGS_POSTPONING config option (no code). bugref:10720

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/target-x86/IEMAllN8veEmit-x86.h (modified) (4 diffs)
• VMMR3/IEMR3.cpp (modified) (1 diff)
• include/IEMInternal.h (modified) (2 diffs)
• include/IEMN8veRecompiler.h (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/target-x86/IEMAllN8veEmit-x86.h

@@ -207 +207 @@
                               )
 {
+    STAM_COUNTER_INC(&pReNative->pVCpu->iem.s.StatNativeEflTotalLogical);
+
 #ifdef IEMNATIVE_WITH_EFLAGS_SKIPPING
     /*
@@ -309 +311 @@
                                  )
 {
+    STAM_COUNTER_INC(&pReNative->pVCpu->iem.s.StatNativeEflTotalArithmetic);
+
 #ifdef IEMNATIVE_WITH_EFLAGS_SKIPPING
     /*
@@ -1557 +1561 @@
                             uint8_t idxRegTmp)
 {
+    STAM_COUNTER_INC(&pReNative->pVCpu->iem.s.StatNativeEflTotalShift);
+
 RT_NOREF(pReNative, off, idxRegEfl, idxRegResult, idxRegSrc, idxRegCount, cOpBits, enmType);
 #if 0 //def IEMNATIVE_WITH_EFLAGS_SKIPPING
@@ -1565 +1571 @@
     if (IEMLIVENESS_STATE_ARE_STATUS_EFL_TO_BE_CLOBBERED(pLivenessEntry))
     {
-        STAM_COUNTER_INC(&pReNative->pVCpu->iem.s.StatNativeEflSkippedLogical);
+        STAM_COUNTER_INC(&pReNative->pVCpu->iem.s.StatNativeEflSkippedShift);
 # ifdef IEMNATIVE_STRICT_EFLAGS_SKIPPING
         off = iemNativeEmitOrImmIntoVCpuU32(pReNative, off, X86_EFL_STATUS_BITS, RT_UOFFSETOF(VMCPU, iem.s.fSkippingEFlags));

trunk/src/VBox/VMM/VMMR3/IEMR3.cpp

@@ -733 +733 @@
         STAMR3RegisterF(pVM, &pVCpu->iem.s.StatNativeEflSkippedArithmetic,      STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_COUNT,
                         "Skipped all status flag updating, arithmetic instructions",
-                        "/IEM/CPU%u/re/NativeEFlagsSkippedArithmetic", idCpu);
-        STAMR3RegisterF(pVM, &pVCpu->iem.s.StatNativeEflSkippedLogical,      STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_COUNT,
+                        "/IEM/CPU%u/re/NativeEFlags/ArithmeticSkipped", idCpu);
+        STAMR3RegisterF(pVM, &pVCpu->iem.s.StatNativeEflTotalArithmetic,        STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_COUNT,
+                        "Total number of arithmetic intructions with status flag updating",
+                        "/IEM/CPU%u/re/NativeEFlags/ArithmeticTotal", idCpu);
+        RTStrPrintf(szPat, sizeof(szPat), "/IEM/CPU%u/re/NativeEFlags/ArithmeticTotal", idCpu);
+        RTStrPrintf(szVal, sizeof(szVal), "/IEM/CPU%u/re/NativeEFlags/ArithmeticSkipped", idCpu);
+        STAMR3RegisterPctOfSum(pVM->pUVM, STAMVISIBILITY_ALWAYS, STAMUNIT_PCT, szVal, false, szPat,
+                               "Skipped all status flag updating, arithmetic instructions, percentage",
+                               "/IEM/CPU%u/re/NativeEFlags/ArithmeticSkippedPct", idCpu);
+
+        STAMR3RegisterF(pVM, &pVCpu->iem.s.StatNativeEflSkippedLogical,         STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_COUNT,
                         "Skipped all status flag updating, logical instructions",
-                        "/IEM/CPU%u/re/NativeEFlagsSkippedLogical", idCpu);
+                        "/IEM/CPU%u/re/NativeEFlags/LogicalSkipped", idCpu);
+        STAMR3RegisterF(pVM, &pVCpu->iem.s.StatNativeEflTotalLogical,           STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_COUNT,
+                        "Total number of logical intructions with status flag updating",
+                        "/IEM/CPU%u/re/NativeEFlags/LogicalTotal", idCpu);
+        RTStrPrintf(szPat, sizeof(szPat), "/IEM/CPU%u/re/NativeEFlags/LogicalTotal", idCpu);
+        RTStrPrintf(szVal, sizeof(szVal), "/IEM/CPU%u/re/NativeEFlags/LogicalSkipped", idCpu);
+        STAMR3RegisterPctOfSum(pVM->pUVM, STAMVISIBILITY_ALWAYS, STAMUNIT_PCT, szVal, false, szPat,
+                               "Skipped all status flag updating, logical instructions, percentage",
+                               "/IEM/CPU%u/re/NativeEFlags/LogicalSkippedPct", idCpu);
+
+        STAMR3RegisterF(pVM, &pVCpu->iem.s.StatNativeEflSkippedShift,           STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_COUNT,
+                        "Skipped all status flag updating, shift instructions",
+                        "/IEM/CPU%u/re/NativeEFlags/ShiftSkipped", idCpu);
+        STAMR3RegisterF(pVM, &pVCpu->iem.s.StatNativeEflTotalShift,             STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_COUNT,
+                        "Total number of shift intructions with status flag updating",
+                        "/IEM/CPU%u/re/NativeEFlags/ShiftTotal", idCpu);
+        RTStrPrintf(szPat, sizeof(szPat), "/IEM/CPU%u/re/NativeEFlags/ShiftTotal", idCpu);
+        RTStrPrintf(szVal, sizeof(szVal), "/IEM/CPU%u/re/NativeEFlags/ShiftSkipped", idCpu);
+        STAMR3RegisterPctOfSum(pVM->pUVM, STAMVISIBILITY_ALWAYS, STAMUNIT_PCT, szVal, false, szPat,
+                               "Skipped all status flag updating, shift instructions, percentage",
+                               "/IEM/CPU%u/re/NativeEFlags/ShiftSkippedPct", idCpu);
 
         STAMR3RegisterF(pVM, &pVCpu->iem.s.StatNativeLivenessEflCfSkippable,    STAMTYPE_COUNTER, STAMVISIBILITY_ALWAYS, STAMUNIT_COUNT, "Skippable EFLAGS.CF updating",       "/IEM/CPU%u/re/NativeLivenessEFlags/CfSkippable", idCpu);

trunk/src/VBox/VMM/include/IEMInternal.h

@@ -2363 +2363 @@
     /** Native recompiler: Number of times status flags calc has been skipped. */
     STAMCOUNTER             StatNativeEflSkippedArithmetic;
+    /** Native recompiler: Total number instructions in this category. */
+    STAMCOUNTER             StatNativeEflTotalArithmetic;
+
     /** Native recompiler: Number of times status flags calc has been skipped. */
     STAMCOUNTER             StatNativeEflSkippedLogical;
+    /** Native recompiler: Total number instructions in this category. */
+    STAMCOUNTER             StatNativeEflTotalLogical;
+
+    /** Native recompiler: Number of times status flags calc has been skipped. */
+    STAMCOUNTER             StatNativeEflSkippedShift;
+    /** Native recompiler: Total number instructions in this category. */
+    STAMCOUNTER             StatNativeEflTotalShift;
 
     /** Native recompiler: Number of opportunities to skip EFLAGS.CF updating. */
@@ -2537 +2547 @@
 
 #ifdef IEM_WITH_TLB_TRACE
-    uint64_t                au64Padding[4];
+    //uint64_t                au64Padding[0];
 #else
-    uint64_t                au64Padding[6];
+    uint64_t                au64Padding[2];
 #endif
 

trunk/src/VBox/VMM/include/IEMN8veRecompiler.h

@@ -50 +50 @@
 #if 1 || defined(DOXYGEN_RUNNING)
 # define IEMNATIVE_WITH_LIVENESS_ANALYSIS
-/*# define IEMLIVENESS_EXTENDED_LAYOUT*/
 #endif
 
@@ -69 +68 @@
 # define IEMNATIVE_STRICT_EFLAGS_SKIPPING
 #endif
+
+/** @def IEMNATIVE_WITH_EFLAGS_POSTPONING
+ * Enables delaying EFLAGS calculations/updating to conditional code paths
+ * that are (hopefully) not taken so frequently.
+ *
+ * This can only help with case where there is an conditional
+ * call/exception/tbexit that needs the flag, but in the default code stream the
+ * flag will be clobbered.  Useful for TlbMiss scenarios and sequences of memory
+ * based instructions clobbering status flags. */
+#if defined(IEMNATIVE_WITH_LIVENESS_ANALYSIS) || defined(DOXYGEN_RUNNING)
+# if 0
+#  define IEMNATIVE_WITH_EFLAGS_POSTPONING
+# endif
+#endif
+
+/** @def IEMLIVENESS_EXTENDED_LAYOUT
+ * Enables the extended liveness data layout.  */
+#if defined(IEMNATIVE_WITH_EFLAGS_POSTPONING) || defined(DOXYGEN_RUNNING) || 0
+# define IEMLIVENESS_EXTENDED_LAYOUT
+#endif
+
 
 #ifdef VBOX_WITH_STATISTICS