VirtualBox

Changeset 48213 in vbox for trunk/src/VBox


Ignore:
Timestamp:
Aug 30, 2013 11:17:51 PM (11 years ago)
Author:
vboxsync
Message:

VMM: Naming fixes and log cosmetics.

Location:
trunk/src/VBox/VMM
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/VMM/VMMR0/HMR0.cpp

    r48212 r48213  
    147147    {
    148148        /* HWCR MSR (for diagnostics) */
    149         uint64_t                    msrHwcr;
     149        uint64_t                    u64MsrHwcr;
    150150
    151151        /** SVM revision. */
     
    618618        {
    619619            /* Read the HWCR MSR for diagnostics. */
    620             g_HvmR0.svm.msrHwcr    = ASMRdMsr(MSR_K8_HWCR);
     620            g_HvmR0.svm.u64MsrHwcr = ASMRdMsr(MSR_K8_HWCR);
    621621            g_HvmR0.svm.fSupported = true;
    622622        }
     
    12661266    pVM->hm.s.vmx.msr.u64Vmfunc         = g_HvmR0.vmx.msr.u64Vmfunc;
    12671267    pVM->hm.s.vmx.msr.u64EptVpidCaps    = g_HvmR0.vmx.msr.u64EptVpidCaps;
    1268     pVM->hm.s.svm.msrHwcr               = g_HvmR0.svm.msrHwcr;
     1268    pVM->hm.s.svm.u64MsrHwcr            = g_HvmR0.svm.u64MsrHwcr;
    12691269    pVM->hm.s.svm.u32Rev                = g_HvmR0.svm.u32Rev;
    12701270    pVM->hm.s.svm.u32Features           = g_HvmR0.svm.u32Features;
  • trunk/src/VBox/VMM/VMMR3/HM.cpp

    r48212 r48213  
    277277    do { \
    278278        if ((allowed1) & (featflag)) \
    279             LogRel(("HM:    " #featflag "\n")); \
     279            LogRel(("HM:   " #featflag "\n")); \
    280280        else \
    281             LogRel(("HM:    " #featflag " *must* be cleared\n")); \
     281            LogRel(("HM:   " #featflag " *must* be cleared\n")); \
    282282        if ((disallowed0) & (featflag)) \
    283             LogRel(("HM:    " #featflag " *must* be set\n")); \
     283            LogRel(("HM:   " #featflag " *must* be set\n")); \
    284284    } while (0)
    285285
     
    287287    do { \
    288288        if ((allowed1) & (featflag)) \
    289             LogRel(("HM:    " #featflag "\n")); \
     289            LogRel(("HM:   " #featflag "\n")); \
    290290        else \
    291             LogRel(("HM:    " #featflag " not supported\n")); \
     291            LogRel(("HM:   " #featflag " not supported\n")); \
    292292    } while (0)
    293293
     
    295295    do { \
    296296        if ((msrcaps) & (cap)) \
    297             LogRel(("HM:    " #cap "\n")); \
     297            LogRel(("HM:   " #cap "\n")); \
    298298    } while (0)
    299299
     
    979979    LogRel(("HM: MSR_IA32_FEATURE_CONTROL        = %#RX64\n", pVM->hm.s.vmx.msr.u64FeatureCtrl));
    980980    LogRel(("HM: MSR_IA32_VMX_BASIC_INFO         = %#RX64\n", pVM->hm.s.vmx.msr.u64BasicInfo));
    981     LogRel(("HM:    VMCS id                                  = %#x\n", MSR_IA32_VMX_BASIC_INFO_VMCS_ID(pVM->hm.s.vmx.msr.u64BasicInfo)));
    982     LogRel(("HM:    VMCS size                                = %u\n", MSR_IA32_VMX_BASIC_INFO_VMCS_SIZE(pVM->hm.s.vmx.msr.u64BasicInfo)));
    983     LogRel(("HM:    VMCS physical address limit              = %s\n", MSR_IA32_VMX_BASIC_INFO_VMCS_PHYS_WIDTH(pVM->hm.s.vmx.msr.u64BasicInfo) ? "< 4 GB" : "None"));
    984     LogRel(("HM:    VMCS memory type                         = %#x\n", MSR_IA32_VMX_BASIC_INFO_VMCS_MEM_TYPE(pVM->hm.s.vmx.msr.u64BasicInfo)));
    985     LogRel(("HM:    Dual-monitor treatment support           = %RTbool\n", !!MSR_IA32_VMX_BASIC_INFO_VMCS_DUAL_MON(pVM->hm.s.vmx.msr.u64BasicInfo)));
    986     LogRel(("HM:    OUTS & INS instruction-info              = %RTbool\n", !!MSR_IA32_VMX_BASIC_INFO_VMCS_INS_OUTS(pVM->hm.s.vmx.msr.u64BasicInfo)));
     981    LogRel(("HM:   VMCS id                             = %#x\n", MSR_IA32_VMX_BASIC_INFO_VMCS_ID(pVM->hm.s.vmx.msr.u64BasicInfo)));
     982    LogRel(("HM:   VMCS size                           = %u\n", MSR_IA32_VMX_BASIC_INFO_VMCS_SIZE(pVM->hm.s.vmx.msr.u64BasicInfo)));
     983    LogRel(("HM:   VMCS physical address limit         = %s\n", MSR_IA32_VMX_BASIC_INFO_VMCS_PHYS_WIDTH(pVM->hm.s.vmx.msr.u64BasicInfo) ? "< 4 GB" : "None"));
     984    LogRel(("HM:   VMCS memory type                    = %#x\n", MSR_IA32_VMX_BASIC_INFO_VMCS_MEM_TYPE(pVM->hm.s.vmx.msr.u64BasicInfo)));
     985    LogRel(("HM:   Dual-monitor treatment support      = %RTbool\n", !!MSR_IA32_VMX_BASIC_INFO_VMCS_DUAL_MON(pVM->hm.s.vmx.msr.u64BasicInfo)));
     986    LogRel(("HM:   OUTS & INS instruction-info         = %RTbool\n", !!MSR_IA32_VMX_BASIC_INFO_VMCS_INS_OUTS(pVM->hm.s.vmx.msr.u64BasicInfo)));
    987987    LogRel(("HM: Max resume loops                = %u\n", pVM->hm.s.cMaxResumeLoops));
    988988
     
    10931093    }
    10941094
    1095     LogRel(("HM: MSR_IA32_VMX_MISC               = %#RX64\n", pVM->hm.s.vmx.msr.u64Misc));
    1096     if (MSR_IA32_VMX_MISC_PREEMPT_TSC_BIT(pVM->hm.s.vmx.msr.u64Misc) == pVM->hm.s.vmx.cPreemptTimerShift)
    1097     {
    1098         LogRel(("HM:    MSR_IA32_VMX_MISC_PREEMPT_TSC_BIT        = %#x\n",
    1099                 MSR_IA32_VMX_MISC_PREEMPT_TSC_BIT(pVM->hm.s.vmx.msr.u64Misc)));
    1100     }
     1095    val = pVM->hm.s.vmx.msr.u64Misc;
     1096    LogRel(("HM: MSR_IA32_VMX_MISC               = %#RX64\n", val));
     1097    if (MSR_IA32_VMX_MISC_PREEMPT_TSC_BIT(val) == pVM->hm.s.vmx.cPreemptTimerShift)
     1098        LogRel(("HM:   MSR_IA32_VMX_MISC_PREEMPT_TSC_BIT      = %#x\n", MSR_IA32_VMX_MISC_PREEMPT_TSC_BIT(val)));
    11011099    else
    11021100    {
    1103         LogRel(("HM:    MSR_IA32_VMX_MISC_PREEMPT_TSC_BIT        = %#x - erratum detected, using %#x instead\n",
    1104                 MSR_IA32_VMX_MISC_PREEMPT_TSC_BIT(pVM->hm.s.vmx.msr.u64Misc), pVM->hm.s.vmx.cPreemptTimerShift));
    1105     }
    1106 
    1107     val = pVM->hm.s.vmx.msr.u64Misc;
    1108     LogRel(("HM:    MSR_IA32_VMX_MISC_STORE_EFERLMA_VMEXIT   = %RTbool\n", !!MSR_IA32_VMX_MISC_STORE_EFERLMA_VMEXIT(val)));
    1109     LogRel(("HM:    MSR_IA32_VMX_MISC_ACTIVITY_STATES        = %#x\n", MSR_IA32_VMX_MISC_ACTIVITY_STATES(val)));
    1110     LogRel(("HM:    MSR_IA32_VMX_MISC_CR3_TARGET             = %#x\n", MSR_IA32_VMX_MISC_CR3_TARGET(val)));
    1111     LogRel(("HM:    MSR_IA32_VMX_MISC_MAX_MSR                = %u\n", MSR_IA32_VMX_MISC_MAX_MSR(val)));
    1112     LogRel(("HM:    MSR_IA32_VMX_MISC_RDMSR_SMBASE_MSR_SMM   = %RTbool\n", !!MSR_IA32_VMX_MISC_RDMSR_SMBASE_MSR_SMM(val)));
    1113     LogRel(("HM:    MSR_IA32_VMX_MISC_SMM_MONITOR_CTL_B2     = %RTbool\n", !!MSR_IA32_VMX_MISC_SMM_MONITOR_CTL_B2(val)));
    1114     LogRel(("HM:    MSR_IA32_VMX_MISC_VMWRITE_VMEXIT_INFO    = %RTbool\n", !!MSR_IA32_VMX_MISC_VMWRITE_VMEXIT_INFO(val)));
    1115     LogRel(("HM:    MSR_IA32_VMX_MISC_MSEG_ID                = %#x\n", MSR_IA32_VMX_MISC_MSEG_ID(val)));
     1101        LogRel(("HM:   MSR_IA32_VMX_MISC_PREEMPT_TSC_BIT      = %#x - erratum detected, using %#x instead\n",
     1102                MSR_IA32_VMX_MISC_PREEMPT_TSC_BIT(val), pVM->hm.s.vmx.cPreemptTimerShift));
     1103    }
     1104
     1105    LogRel(("HM:   MSR_IA32_VMX_MISC_STORE_EFERLMA_VMEXIT = %RTbool\n", !!MSR_IA32_VMX_MISC_STORE_EFERLMA_VMEXIT(val)));
     1106    LogRel(("HM:   MSR_IA32_VMX_MISC_ACTIVITY_STATES      = %#x\n", MSR_IA32_VMX_MISC_ACTIVITY_STATES(val)));
     1107    LogRel(("HM:   MSR_IA32_VMX_MISC_CR3_TARGET           = %#x\n", MSR_IA32_VMX_MISC_CR3_TARGET(val)));
     1108    LogRel(("HM:   MSR_IA32_VMX_MISC_MAX_MSR              = %u\n", MSR_IA32_VMX_MISC_MAX_MSR(val)));
     1109    LogRel(("HM:   MSR_IA32_VMX_MISC_RDMSR_SMBASE_MSR_SMM = %RTbool\n", !!MSR_IA32_VMX_MISC_RDMSR_SMBASE_MSR_SMM(val)));
     1110    LogRel(("HM:   MSR_IA32_VMX_MISC_SMM_MONITOR_CTL_B2   = %RTbool\n", !!MSR_IA32_VMX_MISC_SMM_MONITOR_CTL_B2(val)));
     1111    LogRel(("HM:   MSR_IA32_VMX_MISC_VMWRITE_VMEXIT_INFO  = %RTbool\n", !!MSR_IA32_VMX_MISC_VMWRITE_VMEXIT_INFO(val)));
     1112    LogRel(("HM:   MSR_IA32_VMX_MISC_MSEG_ID              = %#x\n", MSR_IA32_VMX_MISC_MSEG_ID(val)));
    11161113
    11171114    /* Paranoia */
     
    11251122    val = pVM->hm.s.vmx.msr.u64VmcsEnum;
    11261123    LogRel(("HM: MSR_IA32_VMX_VMCS_ENUM          = %#RX64\n", val));
    1127     LogRel(("HM:    MSR_IA32_VMX_VMCS_ENUM_HIGHEST_INDEX     = %#x\n", MSR_IA32_VMX_VMCS_ENUM_HIGHEST_INDEX(val)));
     1124    LogRel(("HM:   MSR_IA32_VMX_VMCS_ENUM_HIGHEST_INDEX   = %#x\n", MSR_IA32_VMX_VMCS_ENUM_HIGHEST_INDEX(val)));
    11281125
    11291126    val = pVM->hm.s.vmx.msr.u64Vmfunc;
     
    12841281    {
    12851282        LogRel(("HM: Nested paging enabled!\n"));
    1286         LogRel(("HM:    EPT root page physaddr       = %#RHp\n", PGMGetHyperCR3(VMMGetCpu(pVM))));
    12871283        if (pVM->hm.s.vmx.enmFlushEpt == VMX_FLUSH_EPT_SINGLE_CONTEXT)
    1288             LogRel(("HM:    EPT flush type               = VMX_FLUSH_EPT_SINGLE_CONTEXT\n"));
     1284            LogRel(("HM:   EPT flush type                = VMX_FLUSH_EPT_SINGLE_CONTEXT\n"));
    12891285        else if (pVM->hm.s.vmx.enmFlushEpt == VMX_FLUSH_EPT_ALL_CONTEXTS)
    1290             LogRel(("HM:    EPT flush type              = VMX_FLUSH_EPT_ALL_CONTEXTS\n"));
     1286            LogRel(("HM:   EPT flush type               = VMX_FLUSH_EPT_ALL_CONTEXTS\n"));
    12911287        else if (pVM->hm.s.vmx.enmFlushEpt == VMX_FLUSH_EPT_NOT_SUPPORTED)
    1292             LogRel(("HM:    EPT flush type              = VMX_FLUSH_EPT_NOT_SUPPORTED\n"));
     1288            LogRel(("HM:   EPT flush type               = VMX_FLUSH_EPT_NOT_SUPPORTED\n"));
    12931289        else
    1294             LogRel(("HM:    EPT flush type              = %d\n", pVM->hm.s.vmx.enmFlushEpt));
     1290            LogRel(("HM:   EPT flush type               = %d\n", pVM->hm.s.vmx.enmFlushEpt));
    12951291
    12961292        if (pVM->hm.s.vmx.fUnrestrictedGuest)
     
    13131309        LogRel(("HM: VPID enabled!\n"));
    13141310        if (pVM->hm.s.vmx.enmFlushVpid == VMX_FLUSH_VPID_INDIV_ADDR)
    1315             LogRel(("HM:    VPID flush type              = VMX_FLUSH_VPID_INDIV_ADDR\n"));
     1311            LogRel(("HM:   VPID flush type               = VMX_FLUSH_VPID_INDIV_ADDR\n"));
    13161312        else if (pVM->hm.s.vmx.enmFlushVpid == VMX_FLUSH_VPID_SINGLE_CONTEXT)
    1317             LogRel(("HM:    VPID flush type              = VMX_FLUSH_VPID_SINGLE_CONTEXT\n"));
     1313            LogRel(("HM:   VPID flush type               = VMX_FLUSH_VPID_SINGLE_CONTEXT\n"));
    13181314        else if (pVM->hm.s.vmx.enmFlushVpid == VMX_FLUSH_VPID_ALL_CONTEXTS)
    1319             LogRel(("HM:    VPID flush type              = VMX_FLUSH_VPID_ALL_CONTEXTS\n"));
     1315            LogRel(("HM:   VPID flush type               = VMX_FLUSH_VPID_ALL_CONTEXTS\n"));
    13201316        else if (pVM->hm.s.vmx.enmFlushVpid == VMX_FLUSH_VPID_SINGLE_CONTEXT_RETAIN_GLOBALS)
    1321             LogRel(("HM:    VPID flush type              = VMX_FLUSH_VPID_SINGLE_CONTEXT_RETAIN_GLOBALS\n"));
     1317            LogRel(("HM:   VPID flush type               = VMX_FLUSH_VPID_SINGLE_CONTEXT_RETAIN_GLOBALS\n"));
    13221318        else
    1323             LogRel(("HM:    VPID flush type              = %d\n", pVM->hm.s.vmx.enmFlushVpid));
     1319            LogRel(("HM:   VPID flush type               = %d\n", pVM->hm.s.vmx.enmFlushVpid));
    13241320    }
    13251321    else if (pVM->hm.s.vmx.enmFlushVpid == VMX_FLUSH_VPID_NOT_SUPPORTED)
     
    13631359    LogRel(("HM: CPUID 0x80000001.u32AMDFeatureECX = %#RX32\n", pVM->hm.s.cpuid.u32AMDFeatureECX));
    13641360    LogRel(("HM: CPUID 0x80000001.u32AMDFeatureEDX = %#RX32\n", pVM->hm.s.cpuid.u32AMDFeatureEDX));
    1365     LogRel(("HM: AMD HWCR MSR                      = %#RX64\n", pVM->hm.s.svm.msrHwcr));
     1361    LogRel(("HM: AMD HWCR MSR                      = %#RX64\n", pVM->hm.s.svm.u64MsrHwcr));
    13661362    LogRel(("HM: AMD-V revision                    = %#x\n",    pVM->hm.s.svm.u32Rev));
    13671363    LogRel(("HM: AMD-V max ASID                    = %RU32\n",  pVM->hm.s.uMaxAsid));
     
    13921388        if (fSvmFeatures & s_aSvmFeatures[i].fFlag)
    13931389        {
    1394             LogRel(("HM:    %s\n", s_aSvmFeatures[i].pszName));
     1390            LogRel(("HM:   %s\n", s_aSvmFeatures[i].pszName));
    13951391            fSvmFeatures &= ~s_aSvmFeatures[i].fFlag;
    13961392        }
     
    13981394        for (unsigned iBit = 0; iBit < 32; iBit++)
    13991395            if (RT_BIT_32(iBit) & fSvmFeatures)
    1400                 LogRel(("HM:    Reserved bit %u\n", iBit));
     1396                LogRel(("HM:   Reserved bit %u\n", iBit));
    14011397
    14021398    /*
     
    14221418    if (pVM->hm.s.fNestedPaging)
    14231419    {
    1424         LogRel(("HM:    Nested paging enabled!\n"));
     1420        LogRel(("HM:   Nested paging enabled!\n"));
    14251421
    14261422        /*
     
    14311427        {
    14321428            PGMSetLargePageUsage(pVM, true);
    1433             LogRel(("HM:    Large page support enabled!\n"));
     1429            LogRel(("HM:   Large page support enabled!\n"));
    14341430        }
    14351431#endif
  • trunk/src/VBox/VMM/include/HMInternal.h

    r48212 r48213  
    404404
    405405        /* HWCR MSR (for diagnostics) */
    406         uint64_t                    msrHwcr;
     406        uint64_t                    u64MsrHwcr;
    407407
    408408        /** SVM revision. */
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette