Changeset 86080 in vbox for trunk/src

Timestamp:

Sep 10, 2020 7:08:06 AM (4 years ago)

Author:

vboxsync

Message:

AMD IOMMU: bugref:9654 Enable INVALIDATE_ALL command support and specify the PCI capability space offset in the ACPI tables as well.

Location:

trunk/src/VBox/Devices

Files:

• Bus/DevIommuAmd.cpp (modified) (4 diffs)
• PC/DevACPI.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp

@@ -1399 +1399 @@
  *
  * @thread  Any.
+ * @remarks The IOMMU lock may or may not be held.
  */
 static void iommuAmdRaiseMsiInterrupt(PPDMDEVINS pDevIns)
@@ -1413 +1414 @@
  *
  * @thread  Any.
+ * @remarks The IOMMU lock may or may not be held.
  */
 static void iommuAmdClearMsiInterrupt(PPDMDEVINS pDevIns)
@@ -2861 +2863 @@
                         iommuAmdRaiseMsiInterrupt(pDevIns);
                 }
-
                 return VINF_SUCCESS;
             }
@@ -4079 +4080 @@
     pThis->ExtFeat.n.u1NoExecuteSup          = 0;
     pThis->ExtFeat.n.u1GstTranslateSup       = 0;
-    pThis->ExtFeat.n.u1InvAllSup             = 0;
+    pThis->ExtFeat.n.u1InvAllSup             = 1;
     pThis->ExtFeat.n.u1GstVirtApicSup        = 0;
     pThis->ExtFeat.n.u1HwErrorSup            = 1;

trunk/src/VBox/Devices/PC/DevACPI.cpp

@@ -3197 +3197 @@
                                        + sizeof(Ivrs.IvhdType10Hpet);
     Ivrs.IvhdType10.u16DeviceId        = PCIBDF_MAKE(uIommuBus, VBOX_PCI_DEVFN_MAKE(uIommuDev, uIommuFn));
-    Ivrs.IvhdType10.u16CapOffset       = 0;             /* 0=No multiple IOMMU functionality. */
+    Ivrs.IvhdType10.u16CapOffset       = IOMMU_PCI_OFF_CAP_HDR;
     Ivrs.IvhdType10.u64BaseAddress     = IOMMU_MMIO_BASE_ADDR;
     Ivrs.IvhdType10.u16PciSegmentGroup = 0;
@@ -3271 +3271 @@
                                        | RT_BF_MAKE(IOMMU_EXT_FEAT_BF_NO_EXEC_SUP,        0)
                                        | RT_BF_MAKE(IOMMU_EXT_FEAT_BF_GT_SUP,             0)
-                                       | RT_BF_MAKE(IOMMU_EXT_FEAT_BF_IA_SUP,             0)
+                                       | RT_BF_MAKE(IOMMU_EXT_FEAT_BF_IA_SUP,             1)
                                        | RT_BF_MAKE(IOMMU_EXT_FEAT_BF_GA_SUP,             0)
                                        | RT_BF_MAKE(IOMMU_EXT_FEAT_BF_HE_SUP,             1)